-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with nanosecond parsing in ParseTemporalTimeZoneString #1795
Comments
Same problem also in
and therefore fraction is TimeZoneUTCOffsetFraction production Then in step 10
so nanoseconds will ALWAYS be 0 in this current algorithm. (hum... maybe that is what I LIKE to see- let the TimeZone offset never be able to set to sub second precision....) I am perfectly fine if we do NOT fix this issue because that is rexactly I hope the champion would agree. Somehow to spec text passing Stage 3 already did that for me :) |
Should we fix this by
to
|
In 13.44 ParseTemporalTimeZoneString ( isoString )
https://tc39.es/proposal-temporal/#sec-temporal-parsetemporaltimezonestring
noitce the definition of TimeZoneUTCOffsetFraction is
Notice TimeZoneUTCOffsetFraction is defined as Fraction, which include DecimalSeparator before TimeFractionalPart
Therefore, if we have a string valid in the syntax of TemporalTimeZoneString as below:
"+23:34:56.987654321"
then TimeZoneUTCOffsetFraction is ".987654321" NOT "987654321"
so step 2 will set fraction to ".987654321"
Then in 6-g
6-g-i set fraction to ".987654321000000000"
6-g-ii set nanoseconds to ".98765432"
6-g-iii set nanoseconds to "0"
Also related to another issue I just reported in #1794
@Ms2ger @ljharb @ptomato @justingrant @ryzokuken
The text was updated successfully, but these errors were encountered: