Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make theme installable #41

Open
MichaelCurrin opened this issue Nov 26, 2020 · 3 comments
Open

Make theme installable #41

MichaelCurrin opened this issue Nov 26, 2020 · 3 comments

Comments

@MichaelCurrin
Copy link
Contributor

MichaelCurrin commented Nov 26, 2020

Hi. I'd like to suggest making changes to the repo and to the docs to allow the theme to be installed as an external theme, in addition to the process of forking and installing as per the Install instructions.

@MichaelCurrin
Copy link
Contributor Author

This would require some changes in the code like adding to .gemspec:

  s.metadata["plugin_type"] = "theme"

And maybe making the name lowercase so match other gems.

  s.name = "dumbarton"

See Minima for example https://github.com/jekyll/minima/blob/master/minima.gemspec

@MichaelCurrin
Copy link
Contributor Author

MichaelCurrin commented Nov 26, 2020

Regarding how to actually install, I've tried this so far based on other projects.

Gemfile

source "https://rubygems.org"

gem 'Dumbarton', git: 'https://github.com/tcbutler320/Jekyll-Theme-Dumbarton'

I ran bundle install which also installed Jekyll 4.

$ ls vendor/bundle/ruby/2.7.0/bundler/gems/Jekyll-Theme-Dumbarton-6f6b0338a723
404.html       _config.yml         contributing.md     package.json
...

Config

Then I set my config value but get an error.

My config

theme: Dumbarton
Jekyll::Errors::MissingDependencyException: The dumbarton theme could not be found.

Or

theme: Jekyll-Theme-Dumbarton
Jekyll::Errors::MissingDependencyException: The jekyll-theme-dumbarton theme could not be found.

@tcbutler320
Copy link
Owner

Hey @MichaelCurrin sorry to leave you hanging on this! Yes this is something I want to implement, I will likely take a look into theses suggestions and work on a solution later this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants