Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Symfony's dotenv path #156

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

Ramblurr
Copy link
Contributor

@Ramblurr Ramblurr commented Apr 1, 2024

This commit introduces the environment variable ENV_DIR.

When provided, davis will load env files (.env, .env.local, etc.) from this folder instead of loading them from the default location (which is the folder containing composer.json)

As discussed in #154.

@Ramblurr Ramblurr force-pushed the feat/env-directory branch from 90af743 to 5e46fa4 Compare April 1, 2024 12:41
@Ramblurr
Copy link
Contributor Author

Ramblurr commented Apr 1, 2024

Updated the readme numbering given the good news from #155

bin/console Outdated Show resolved Hide resolved
bin/console Outdated Show resolved Hide resolved
This commit introduces the environment variable `ENV_DIR`.

When provided, davis will load env files (`.env`, `.env.local`, etc.)
from this folder instead of loading them from the default
location (which is the folder containing `composer.json`)

As discussed in tchapi#154.
@Ramblurr Ramblurr force-pushed the feat/env-directory branch from 5e46fa4 to 6e95b0d Compare April 1, 2024 19:26
@Ramblurr
Copy link
Contributor Author

Ramblurr commented Apr 1, 2024

Changes made :)

@tchapi tchapi added the enhancement New feature or request label Apr 1, 2024
@tchapi tchapi merged commit cca8ed3 into tchapi:main Apr 1, 2024
4 checks passed
Ramblurr added a commit to Ramblurr/nixpkgs that referenced this pull request Apr 3, 2024
* Our patchset is no longer required (see tchapi/davis#156)
* Though the upstream var names changed, so we had to update those too
* These vars are managed by the nixos module and hence are not breaking
  changes for users of the module.
* Also removed need to specify postgres charset in non-standard way
  (see tchapi/davis#153)

Release notes: https://github.com/tchapi/davis/releases/tag/v4.4.2
@Ramblurr Ramblurr mentioned this pull request Apr 3, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants