Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten user entity to a github account #17

Open
nikita715 opened this issue Oct 13, 2018 · 4 comments
Open

Flatten user entity to a github account #17

nikita715 opened this issue Oct 13, 2018 · 4 comments
Labels
area/client Issue related to web client. area/server Issue related to server. kind/enhancement Proposal for an improvement.

Comments

@nikita715
Copy link
Contributor

I can't logout from github for no reason. The button is inactive.

oct-14-2018 01-05-57

@tcibinan tcibinan added the kind/enhancement Proposal for an improvement. label Oct 15, 2018
@tcibinan
Copy link
Owner

@nikita715 Thank you for creating the issue.

Currently, there is no implementation for github log out and the button itself is just a mock.

There are several reasons why it is so.

  1. If user wants to log in with another github account then what does it mean in terms of courses? From my point of view, we should transform existing courses to a read-only state. But I can't tell is it an expected behavior or not.
  2. Another issue is that codacy and travis tokens are linked to a single github account. Therefore, if user changes his github account then he has to change his codacy and travis tokens as well.

Probably, some kind of configurations can be of use here. Configuration can aggregate github+travis+codacy tokens into a single entity.

@nikita715
Copy link
Contributor Author

As far as I understand, github account identifies solutions of each student. I think you should move github auth to the registry if there is no reason and no possibility to logout from it. Or maybe the registry should be done only via github to form the closest relation with account in your system.

@tcibinan
Copy link
Owner

It sounds reasonable. Moreover, Travis and Codacy have the same mechanism as you described. It will also make Bitbucket or GitLab integrations easier.

@tcibinan
Copy link
Owner

So the current implementation plan is the following:

  • flatten user account structure removing username and password fields
  • use github username wherever account username was used
  • replace basic auth with jwt token auth

@tcibinan tcibinan changed the title Impossible to logout from github Flatten user entity to a github account Oct 17, 2018
@tcibinan tcibinan added area/client Issue related to web client. area/server Issue related to server. labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client Issue related to web client. area/server Issue related to server. kind/enhancement Proposal for an improvement.
Projects
None yet
Development

No branches or pull requests

2 participants