Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on github profile names #19

Open
tcibinan opened this issue Oct 22, 2018 · 0 comments
Open

Do not rely on github profile names #19

tcibinan opened this issue Oct 22, 2018 · 0 comments
Labels
area/server Issue related to server. integration/github Issue related to GitHub integration. kind/bug Something doesn't work as expected.

Comments

@tcibinan
Copy link
Owner

Problem

Currently, github user profile name is used as a user unique identificator which is completely wrong.

F.e. if a student changes his nickname then he will be classified as a new student. Therefore, two students in the task results table can be a single one in the reality.

Solution

Store not only student and user github profile names but also their ids. All identification should based on a github user id rather than profile name.

@tcibinan tcibinan added the kind/bug Something doesn't work as expected. label Oct 22, 2018
@tcibinan tcibinan added the area/server Issue related to server. label May 25, 2019
@tcibinan tcibinan added the integration/github Issue related to GitHub integration. label Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server Issue related to server. integration/github Issue related to GitHub integration. kind/bug Something doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

1 participant