Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globby does not find package.json files under windows #152

Closed
mhohmeier opened this issue Nov 5, 2019 · 1 comment · Fixed by #157
Closed

globby does not find package.json files under windows #152

mhohmeier opened this issue Nov 5, 2019 · 1 comment · Fixed by #157
Labels
bug 🪲 Something isn't working

Comments

@mhohmeier
Copy link

Hi!
Since Version 10.0.0, globby only allows forward slashes in patterns. This can be found here:
https://github.com/sindresorhus/globby/releases/tag/v10.0.0 and here
https://github.com/mrmlnc/fast-glob/releases/tag/3.0.0

getFileList.js in this repository uses path.sep which is "\" on Windows.
This leads to globby not finding any package.json file, and therefore no package.json file being linted on Windows.

I suggest replacing all '\' path separators with '/'. In fact i tried making a pull request myself but your lint tests also rely on forward slasehd (i.e. getIgnorer.test.js, l. 66).

Or am i missing something?

Thanks!

@tclindner
Copy link
Owner

Hey @mhohmeier! Sorry about that. I didn't catch the path separator change in fast-glob (dep of globby). I've released v4.0.5. All path.sep instances have been replaced with /. Please let me know if you have additional issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants