Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Remove ecs and fargate legacy code #92

Open
sjockers opened this issue May 8, 2023 · 2 comments
Open

Housekeeping: Remove ecs and fargate legacy code #92

sjockers opened this issue May 8, 2023 · 2 comments

Comments

@sjockers
Copy link
Collaborator

sjockers commented May 8, 2023

There's a provisioning script for ECS in this repo and a reference to Fargate in the readme. Is this actually meant to be used or is it legacy code/infrastructure? My understanding was that the resulting Docker image is used in this GH workflow. Or am I missing something?

@sjockers
Copy link
Collaborator Author

sjockers commented May 8, 2023

Also, maybe related, I was wondering why the cron schedule is commented out for the harvesters – e.g. here: https://github.com/technologiestiftung/giessdenkiez-de/blob/master/.github/workflows/rain.yml#L7-L8

@ff6347
Copy link
Collaborator

ff6347 commented May 8, 2023

Yes the fargate/ecs stuff is legacy code and can be removed. We had it first running as aws fargate but moved it to GitHub Actions for more transparency.

Also, maybe related, I was wondering why the cron schedule is commented out for the harvesters – e.g. here: technologiestiftung/giessdenkiez-de@master/.github/workflows/rain.yml#L7-L8

The cron schedule is commented out because we use repository_dispatch actions. If a repo development is stale (no commits happening) a schedule action is paused after 60 (or was it 90) days. We moved to cronjobs running on pipedream.com using repo dispatch to be sure that all jobs keep running.

@ff6347 ff6347 changed the title What is Amazon ECS/Fargate used for? Housekeeping: Remove ecs and fargate legacy code May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants