Remove usage of xml_set_object() function #734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Jul 25, 2024
andrewnicols
approved these changes
Oct 9, 2024
williamdes
approved these changes
Oct 9, 2024
The xml_set_object() function will be deprecated in PHP 8.4 as well as passing non-callable strings to the xml_set_*_handler() functions. Instead of using xml_set_object(), the string method names in xml_set_element_handler() and xml_set_character_data_handler() should be replaced with callables. - https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
force-pushed
the
xml_set_object-deprecation
branch
from
3dd817b to
53990c6
Compare
|
OK - Manually merged: #755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xml_set_object()function will be deprecated in PHP 8.4 as well as passing non-callable strings to thexml_set_*_handler()functions.Instead of using
xml_set_object(), the string method names inxml_set_element_handler()andxml_set_character_data_handler()should be replaced with callables.