ConnectionPools in async code appear to be broken in 6.1.0

[ghost]

This is precisely the kind of code that was broken in the update due to this change. I believe this should be listed as either a known bug or as a deliberately deprecated functionality.

const pool = new sql.ConnectionPool(config)
  .connect()
  .then(pool => {
    console.log('New Connection to MSSQL')
    return pool
  }).catch(err => {
    console.log('Database Connection Failed! Bad Config: ', err)
  })

async function dbExecuteQuery(arg){
  const conn = await pool
  const request = new sql.Request(conn)

  if (arg.input) {
    arg.input.forEach(element => {
      request.input(element.name, element.value)
    });
  }

  return request.query(arg.query, arg.input)
  .then(pass=>{
    dbLogQuery(arg, pass)
    return pass
  }).catch(error=>{
    throw error
  })
}

I might write bad code, but it's bad code that worked in 6.0.1.

Originally posted by @Jack-CHS-PWD in #941 (comment)

[ghost]

When attempting to execute a query, 6.1.0 will return the error "ConnectionError Cannot call write after a stream was destroyed"

Later queries in the same application instance will return the error "RequestError: No connection is specified for that request."

My assumption is that the ConnectionPool is being closed erroneously immediately, leading to the first error, and being garbage collected shortly after, causing the second.

Rolling back to 6.0.1, however, still works as intended.

[dhensby]

Hmmm, that's strange, that code looks like it should be fine, there's no code closing the pool, so I'm not sure how you're getting errors.

[dhensby]

This looks like a duplicate of #993

[ghost]

It was, thank you.