ci: improve github actions #1573
Conversation
dhensby
commented
Sep 14, 2023
•
dhensby
commented
- The setup-node action automatically stores caches for NPM and uses the same logic as the current action implementation, so there's no need to duplicate it in the action definition.
- Remove redundant NPM upgrade step - v6.x of Node is no longer tested/supported.
- Linting step does not need complete repository history.
- Use setup-sqlserver action to install SQL Server
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
=======================================
Coverage 78.25% 78.25%
=======================================
Files 93 93
Lines 4879 4879
Branches 937 937
=======================================
Hits 3818 3818
Misses 762 762
Partials 299 299 ☔ View full report in Codecov by Sentry. |
dhensby
force-pushed
the
pulls/action-improvements
branch
3 times, most recently
from
04e5199 to
a4a44cb
Compare
|
@dhensby Would you mind resolving the conflicts with the latest changes that happened on |
The setup-node action automatically stores caches for NPM and uses the same logic as the current action implementation, so there's no need to duplicate it in the action definition.
The npm upgrade steps in CI only run if the matrix version for node is 6.x but 6.x is not a tested version of node in any of the matrix definitions.
The linting step does not need the entire repository history to run. Only checkout the minimal history to allow faster lint step.
dhensby
force-pushed
the
pulls/action-improvements
branch
from
a4a44cb to
d3fa7f3
Compare
|
@arthurschreiber done. I had also wanted to replace lots of the repeated SQL Server installer code with the setup-sqlserver action, but I'm not sure it's an entirely 1-to-1 replacement |
|
@dhensby It'd be great if |
|
@arthurschreiber - working on it: tediousjs/setup-sqlserver#45 |
|
I never quite understood why this didn't work out of the box. The installer has an option ( |
|
I stopped trying to understand the SQL installer a long time ago! 😬 |
dhensby
force-pushed
the
pulls/action-improvements
branch
3 times, most recently
from
9714b6b to
b59813c
Compare
dhensby
force-pushed
the
pulls/action-improvements
branch
from
b59813c to
9466826
Compare
|
@arthurschreiber looks like it's working, one of the tests hit a timeout and needs restarting |
|
🎉 we are green |
|
🎉 This PR is included in version 18.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
