fix: don't throw in _transform of BulkLoad #1590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an
uncaughtException
, caused by trying to write a very large (negative) number using BulkLoad to a decimal column. Seems similar to #421. The stack trace I got:bulk-load:209 is inside the _tranform function, for which I think the following in the nodejs documentation holds:
Therefore, I propose to catch such errors and call the callback with it. I verified that solved my case.