-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include instance name in Login7
message and traceID in prelogin
#1668
Open
TPVallancourt
wants to merge
4
commits into
tediousjs:master
Choose a base branch
from
hightouchio:tpvallancourt/fix-login7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: include instance name in Login7
message and traceID in prelogin
#1668
TPVallancourt
wants to merge
4
commits into
tediousjs:master
from
hightouchio:tpvallancourt/fix-login7
+43
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPVallancourt
changed the title
Move FeatureExtensions to end of Login7 Packet + use full server name for Login7
fix: Move FeatureExtensions to end of Login7 Packet + use full server name for Login7
Oct 29, 2024
Hi @arthurschreiber , are there any other things I need to do get this incorporated into the library? |
arthurschreiber
changed the title
fix: Move FeatureExtensions to end of Login7 Packet + use full server name for Login7
fix: include instance name in Nov 10, 2024
Login7
message
@TPVallancourt This seems to break the appveyor build on Windows 🤔 |
@@ -2484,7 +2485,7 @@ class Connection extends EventEmitter { | |||
} | |||
|
|||
payload.hostname = this.config.options.workstationId || os.hostname(); | |||
payload.serverName = this.routingData ? this.routingData.server : this.config.server; | |||
payload.serverName = this.routingData ? `${this.routingData.server}\\${this.routingData.instance}` : this.config.server; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is instance
here guaranteed to always be a non-empty string? What happens if it's empty?
TPVallancourt
changed the title
fix: include instance name in
fix: include instance name in Dec 5, 2024
Login7
messageLogin7
message and traceID in prelogin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1563
instance
. Previously we just savedserver
which removes the instance name from the redirect URL. This is the proper string for TLS negotiation, but Login7 needs theserver
and theinstance
together.prelogin
payload, include a randomly generated traceID, Starting with TDS37.0 it seems that traceID is no longer optional for Fabric.