Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOLANGCI-LINT timeout failing build/integration tests for PRs #187

Closed
priyawadhwa opened this issue Aug 9, 2021 · 1 comment · Fixed by #188
Closed

GOLANGCI-LINT timeout failing build/integration tests for PRs #187

priyawadhwa opened this issue Aug 9, 2021 · 1 comment · Fixed by #188
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@priyawadhwa
Copy link
Contributor

priyawadhwa commented Aug 9, 2021

This seems similar to tektoncd/plumbing#241, which the tektoncd/pipeline repo faced in early 2020.

Seems like the fix was adding more nodes to the prow cluster and upgrading golangci-lint to a version which used less memory (1.27).

Our current version already incorporates those changes (1.41) so we could look into adding more nodes to the prow cluster.

For now, I'll try increasing the timeout to 10m and see if that resolves things.

@priyawadhwa priyawadhwa added the kind/bug Categorizes issue or PR as related to a bug. label Aug 9, 2021
@priyawadhwa
Copy link
Contributor Author

seems like CPU usage has been hitting 100% over the past few hours but not too often. the build test passed on #188 also passed in <2 minutes, so maybe the cluster just isn't under as much load anymore

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant