Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to print PipelineRun when calling tkn pipeline start #372

Closed
ghost opened this issue Oct 21, 2019 · 6 comments · Fixed by #643
Closed

Flag to print PipelineRun when calling tkn pipeline start #372

ghost opened this issue Oct 21, 2019 · 6 comments · Fixed by #643
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@ghost
Copy link

ghost commented Oct 21, 2019

Expected Behavior

I'd like to be able to see the PipelineRun that tkn generates before I decide to actually start it.

Actual Behavior

At the moment tkn pipeline start runs the pipeline but cannot show me what the PipelineRun will be before I start it.

Steps to Reproduce the Problem

  1. tkn pipeline start

Additional Info

I'm using tkn for a public release of Tekton Pipelines. Before I commit the PipelineRun that will do the release I'd like to review it (and maybe even copy/paste it somewhere else for other people to see).

@danielhelfand
Copy link
Member

So this reminds me a lot of how terraform has a terraform plan command that allows someone to view what is about to happen before an action command is run.

Perhaps something like tkn pipeline start pipeline-name -r resource=pipeline_resource --plan would output a similar description to a tkn pr describe?

@chmouel
Copy link
Member

chmouel commented Oct 21, 2019

I would imaging something more like --dry-run that would just output a yaml file instead so we can apply it manually after (or use start --dry-run as a generator before versioning)?

@chmouel
Copy link
Member

chmouel commented Oct 21, 2019

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2019
@chmouel chmouel added this to the 0.6.0 milestone Oct 21, 2019
@danielhelfand
Copy link
Member

danielhelfand commented Oct 21, 2019

@chmouel I think supporting both an option for a file but also having an option to view it just via output would make sense. But think --dry-run works for sure.

@chmouel
Copy link
Member

chmouel commented Oct 21, 2019

@danielhelfand Fair enough! let's capture both then :)

@danielhelfand
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants