From 053823d5cae59a57bd8e95878a4c3a8b4cf313a2 Mon Sep 17 00:00:00 2001 From: Scott Nichols Date: Wed, 12 May 2021 14:05:47 -0700 Subject: [PATCH 1/2] Update pipelines.md Website needs bullet points to be 4 spaces to render correctly. See https://tekton.dev/docs/pipelines/pipelines/#adding-tasks-to-the-pipeline for the issue. --- docs/pipelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/pipelines.md b/docs/pipelines.md index 2fd49892435..13f4d14e040 100644 --- a/docs/pipelines.md +++ b/docs/pipelines.md @@ -69,8 +69,8 @@ A `Pipeline` definition supports the following fields: `Pipeline` object. For example, a `name`. - [`spec`][kubernetes-overview] - Specifies the configuration information for this `Pipeline` object. This must include: - - [`tasks`](#adding-tasks-to-the-pipeline) - Specifies the `Tasks` that comprise the `Pipeline` - and the details of their execution. + - [`tasks`](#adding-tasks-to-the-pipeline) - Specifies the `Tasks` that comprise the `Pipeline` + and the details of their execution. - Optional: - [`resources`](#specifying-resources) - **alpha only** Specifies [`PipelineResources`](resources.md) needed or created by the `Tasks` comprising the `Pipeline`. From 567dce3cc4f4b732cb1b3bb86e9c66bdd2406487 Mon Sep 17 00:00:00 2001 From: Scott Date: Mon, 10 May 2021 13:29:03 -0400 Subject: [PATCH 2/2] Change the way we run e2e tests with feature gates in pipelines Prior to this commit pipelines ran e2e tests for both "stable" and "alpha" feature gates in a single prow job. This makes the tests take twice as long as running running either individually. In a parallel commit to Plumbing we are introducing a new prow job that is specifically for running alpha e2e tests. This means both the alpha and stable tests can be run concurrently and hopefully should reduce the iteration time on PRs - failures should show up sooner. The alpha feature gate prow job will set the PIPELINE_FEATURE_GATE env var when it is initiated. Our e2e script recognizes this var and sets the feature-flags configmap accordingly. If the env var is not set then we default to running under "stable" feature gate. --- test/e2e-tests.sh | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/e2e-tests.sh b/test/e2e-tests.sh index 8480bbc1afb..4a077e56a3e 100755 --- a/test/e2e-tests.sh +++ b/test/e2e-tests.sh @@ -52,11 +52,14 @@ function run_e2e() { go_test_e2e -tags=examples -timeout=20m ./test/ || failed=1 } -set_feature_gate "stable" -run_e2e +if [ "$PIPELINE_FEATURE_GATE" == "" ]; then + set_feature_gate "stable" + run_e2e +else + set_feature_gate "$PIPELINE_FEATURE_GATE" + run_e2e +fi -set_feature_gate "alpha" -run_e2e (( failed )) && fail_test success