From de5493e003045af923e926e587459ebee546051d Mon Sep 17 00:00:00 2001 From: Vincent Demeester Date: Wed, 18 Dec 2019 12:52:00 +0100 Subject: [PATCH] =?UTF-8?q?Remove=20SCRIPT=5FROOT,=20CODEGEN=5FPKG=20and?= =?UTF-8?q?=20KNATIVE=5FCODEGEN=5FPKG=20env=20=F0=9F=98=85?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Those environment variables are not used in the rest of the script and thus consume resources (`go list …`) for nothing. Signed-off-by: Vincent Demeester --- hack/update-codegen.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hack/update-codegen.sh b/hack/update-codegen.sh index 917072a8565..f730a19cb8f 100755 --- a/hack/update-codegen.sh +++ b/hack/update-codegen.sh @@ -20,11 +20,6 @@ set -o pipefail source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh -SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. -CODEGEN_PKG=${CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' k8s.io/code-generator)} - -KNATIVE_CODEGEN_PKG=${KNATIVE_CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' knative.dev/pkg)} - # generate the code with: # --output-base because this script should also be able to run inside the vendor dir of # k8s.io/kubernetes. The output-base is needed for the generators to output into the vendor dir