Should we keep the vendor directory or not?

[ghost]

Since we migrated to go modules a while ago there's been a lingering question of whether we should keep the vendor directory or not. It seems like there are several benefits to keeping it:

1. CI runs faster than if it re-fetches all the deps every time it runs.
2. Some developers are required to include the vendor directory per their company's policies.

This issue is intended to focus the conversation around the vendor directory in one place.

[dlorenc]

I just stumbled on this, but I'm in favor of keeping the directory. Without it, it's hard to review the code we're depending on.

[vdemeester]

Ah, never commented on this one (but on the go module support, here). Overall, I don't see any reason for removing the vendor folder.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[ghost]

I'm going to go ahead and close this. We can revisit if the question ever arises again in future.