Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ConfigMap watcher for feature-flags #2117

Closed
ghost opened this issue Feb 27, 2020 · 0 comments · Fixed by #2637
Closed

Introduce ConfigMap watcher for feature-flags #2117

ghost opened this issue Feb 27, 2020 · 0 comments · Fixed by #2637
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ghost
Copy link

ghost commented Feb 27, 2020

Expected Behavior

Checking feature-flags shouldn't be a costly operation. We could use a ConfigMap watcher to do this. There's code demonstrating configmap watching in pipelines already.

Actual Behavior

Each feature-flag lookup is a call to the kubernetes API for the flag value.
@ghost ghost added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 27, 2020
@ghost ghost added this to the Pipelines 1.0/beta 🐱 milestone Feb 27, 2020
@ghost ghost mentioned this issue Feb 27, 2020
Merged
3 tasks
@bobcatfish bobcatfish modified the milestones: Pipelines 1.0/beta 🐱, Pipelines 1.1 / Post-beta 🐱 Mar 16, 2020
@afrittoli afrittoli removed this from the Pipelines Post-beta 🐱 milestone May 4, 2020
@adshmh adshmh mentioned this issue May 17, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce config map watcher for feature flags adshmh/pipeline
2 participants
@bobcatfish @afrittoli