Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace validation misses undefined Workspaces in TaskRuns #2176

Closed
ghost opened this issue Mar 6, 2020 · 2 comments · Fixed by #2177
Closed

Workspace validation misses undefined Workspaces in TaskRuns #2176

ghost opened this issue Mar 6, 2020 · 2 comments · Fixed by #2177
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
Pipelines 0.11 🐱

Comments

@ghost
Copy link

ghost commented Mar 6, 2020

Expected Behavior

Validation should fail if a Workspace is not provided.

Actual Behavior

A TaskRun is allowed to execute even if a Workspace that's expected by the Task is not provided. No errors are printed until runtime when the Task's steps try and access the volume mounted for the workspace.

Steps to Reproduce the Problem

  1. Run the workspace.yaml example with the TaskRun's workspaces removed.

Additional Info

Originally identified in #2119 (comment)
@vdemeester
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 6, 2020
@vdemeester vdemeester added this to the Pipelines 0.11 🐱 milestone Mar 6, 2020
@vdemeester
Copy link
Member

/assign @sbwsg

@tekton-robot tekton-robot assigned ghost Mar 6, 2020
@ghost ghost mentioned this issue Mar 6, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
Pipelines 0.11 🐱
Development

Successfully merging a pull request may close this issue.

Missing Workspaces should be cause for failure
2 participants
@vdemeester @tekton-robot