-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PipelineRun timeouts delete TaskRun related pods #4035
Comments
/kind feature One possible exploration to do here would be to make the entrypoint handle the timeout somehow. That way, we could stop the execution of the pod/containers without deleteting it. |
Related to the behaviour of "cancel" - see #3238 |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale I doubt we want to close this, it is an important feature to have as it will make the timeouts really useful |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale I doubt we want to close this, it is an important feature to have as it will make the timeouts really useful |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/lifecycle frozen |
The current implementation of the PipelineRun timeout is done through deleting the TaskRun associated pods. While this is an understandable implementation as there is no easy way to stop a pod, it makes the debugging of a PipelineRun that has failed completely impossible. It also took me a while to understand why the related pods were being deleted.
In the current shape, the PipelineRun timeout may not be very helpful for people that need to access the logs of the failed TaskRuns. It may be helpful to add a note in the docs about how timeouts are being implemented so that people choose wisely if they want to use the feature.
Since pipeline timeouts are a very desirable feature, they should be implemented in a way that keeps the underlying pods available for debugging purposes.
The text was updated successfully, but these errors were encountered: