Mark PipelineRun completed after binded PVCs are deleted

[QuanZhang-William]

Feature request

Background

Today, the pvcs created from PipelineRun's VolumeClaimTemplate is not automatically deleted at PipelineRun completion time by default. We have a user request to allow PVC to be deleted when a PipelineRun is completed. In TEP-0135, we have enforced such PVCs to be deleted at the PipelineRun's completion time in the new Affinity Assistant mode (i.e. coschedule: pipelineruns).

The pvcs are currently deleted in a "fire and forget" manner. The PipelineRun is marked as completed right after we call the APIServer to delete the pvcs (without checking if the pvcs are successfully deleted or not).

Proposal

@lbernick suggested that one potential improvement is to mark the PipelineRun completed after validating the pvcs are successfully deleted (i.e. we made another API call to try to get the pvcs)

Use case

Pros

• There is no uncertainty of the pvc state when the owning PipelineRun is completed
• Reduce test flakiness when validating pvc state after a PipelineRun is completed in our integration test
  • (We saw flakiness when pvcs are not yet deleted due to slow nodes after the PipelineRun is marked completed, which causes tests to fail)

Cons

• Increasing PipelineRun completion latency
• Potential PipelineRun timeout due to slow nodes to delete pvcs
• What is the right state of the PipelineRun if the pvc deletion is failed?

This issue is created to collect more feedbacks from community, please let me know!

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[vdemeester]

/remove-lifecycle stale