We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
Just migrating from legacy telepresence and dropping in telepresence 2 with existing use of legacy telepresence panicked.
Stack trace led me to the
startInDocker function in the
startInDocker
https://github.com/telepresenceio/telepresence/blob/release/v2/pkg/client/cli/intercept/state.go
file.
Specifically the attempt to extract the value of the '--name' option:
name, hasName := getArg("--name")
fails and panics in the getArg function:
getArg
if i+1 < len(args) { return parts[i+1], true
As it is assumed the parts array has enough elements, which is not the case if the --name option is of the form
parts
--name
--name the-name
rather than:
--name=the-name
as the string is only split on '=':
parts := strings.Split(arg, "=")
To Reproduce
run telepresence v2 using legacy options and in the --docker-run arguments specify --name the-name not --name=the-name
telepresence --swap-deployment deployment-name --namespace blah --docker-run --name the-name ...
Expected behavior telepresence to not panic and to run the docker container as specified
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered:
thallgren
Successfully merging a pull request may close this issue.
Describe the bug
Just migrating from legacy telepresence and dropping in telepresence 2 with existing use of
legacy telepresence panicked.
Stack trace led me to the
startInDocker
function in thehttps://github.com/telepresenceio/telepresence/blob/release/v2/pkg/client/cli/intercept/state.go
file.
Specifically the attempt to extract the value of the '--name' option:
name, hasName := getArg("--name")
fails and panics in the
getArg
function:As it is assumed the
parts
array has enough elements, which is not the case if the--name
option is of the form--name the-name
rather than:
--name=the-name
as the string is only split on '=':
To Reproduce
run telepresence v2 using legacy options and in the --docker-run arguments specify
--name the-name
not--name=the-name
Expected behavior
telepresence to not panic and to run the docker container as specified
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered: