Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reposition EOL note, remove VR classroom note #593

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

filipKovachev
Copy link
Contributor

@filipKovachev filipKovachev commented Jul 4, 2024

I am removing the VR classroom note and moving the Vue EOL one to the bottom of the article for better readability.

@filipKovachev filipKovachev self-assigned this Jul 4, 2024
@filipKovachev filipKovachev requested a review from a team July 15, 2024 07:15
@filipKovachev filipKovachev marked this pull request as ready for review July 15, 2024 07:15
@yordan-mitev
Copy link
Contributor

I added a review of Getting Started with JS and Options API as a PR: #601.
Please review before merging, I added additional explanations and moved some of the code snippets. Please check if the changes make sense and are technically correct.

Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review provided as a PR.


## Add Application Data

Add dummy data needed by the components. Create folder `appdata` in the `src` folder. Add the following files to the `appdata` folder.

1. Create a new `appdata/categories.ts` file. Copy the content of [this GitHub file](https://github.com/telerik/kendo-vue/tree/master/getting-started-nuxt3/appdata/categories.ts) and paste it into the `categories.ts` file.

1. Create a new `appdata/products.ts` file. Copy the content of [this GitHub file](https://github.com/telerik/kendo-vue/tree/master/getting-started-nuxt3/appdata/products.ts) and paste it into the `products.ts` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a single step where you add a single file, adjust the text so that it addresses this change:

Add the dummy data needed by the components:

  1. In the src folder, create a new folder called appdata.
  2. In the appdata folder, create a new file called products.ts.
  3. Copy the content of this GitHub file and paste it into the products.ts file.


1. Add a `<script>` block to the `pages/KendoGrid.vue` file, import the Grid and its data. In addition, the `process` function from the [Data Query](https://www.telerik.com/kendo-vue-ui/components/dataquery/) package will allow you to apply data operations like sorting, paging, and filtering.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing script tag in my version of the app. Maybe we need to add the new content inside the existing tags?

import { process, type DataResult, type State, type SortDescriptor } from '@progress/kendo-data-query';
import { Grid as grid } from '@progress/kendo-vue-grid';
</script>
```

1. Add a `<template>` block with a simple heading and create a Data Grid. Bind it to the `products` data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my version of the app, the template block exists and has some content. Should we add the new content in the existing block?

<template>
  <div>
    Page: KendoGrid
  </div>
</template>

] as GridColumnProps[];
```

After completing all the steps above, your `KendoGrid.vue` will look like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The first three imports should probably be in the <script> block.
  • The content of the code snippet must be indented because it isn't rendered as a code block.

This sample code lets you run an application with a very basic Grid:

1. Execute the `npm run dev` command.
1. Navigate to the local URL displayed in the terminal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app doesn't run with this code, multiple errors are thrown about KendoGrid.vue.

]);
```
```js
<script lang="ts">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script tag changes its lang here. It is not consistent with the previous code snippets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants