Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open empty page option (no URL passed) #189

Closed
nikitavoloboev opened this issue Aug 22, 2020 · 2 comments · Fixed by #192
Closed

Open empty page option (no URL passed) #189

nikitavoloboev opened this issue Aug 22, 2020 · 2 comments · Fixed by #192
Labels

Comments

@nikitavoloboev
Copy link

nikitavoloboev commented Aug 22, 2020

In Safari prefs you can set to open empty page when new tab is open:

image

If it is set, I thought if I set this in Vimari prefs:

"openTabUrl": "",

It would open an empty page too but it doesn't. It opens DuckDuckGo page for me still.

Would be good to support empty string syntax in openTabUrl to mean open empty page.

@nbelzer
Copy link
Collaborator

nbelzer commented Aug 22, 2020

I would like to see this as well but unfortunately this seems to be a limitation in the API provided by Apple.

If the extension cannot access the URL, no tab is opened.


Having said that I'm not sure why we open the tab in this manner as we could use the window.open function. Testing this real quick it would allow you to specify urls that are not possible now like topsites:// or as you mentioned "". Unless I find a reason for the current way of opening a tab this seems like the way to go.

@nbelzer nbelzer added the good first issue Good for newcomers label Aug 22, 2020
@danielcompton
Copy link
Member

The current way of opening the tab uses Apple's native APIs, but as you noticed it only lets you open HTTP and HTTPS URLs. Switching to window.open seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants