Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues while using Vimari with Normal mode and Insert mode #201

Open
gaisin opened this issue Sep 12, 2020 · 4 comments
Open

Issues while using Vimari with Normal mode and Insert mode #201

gaisin opened this issue Sep 12, 2020 · 4 comments

Comments

@gaisin
Copy link

gaisin commented Sep 12, 2020

First of all, thanks a lot to @nbelzer for developing the product. Here is my short feedback of using for couple of days, mostly it touches PR #176.

Is your feature request related to a problem? Please describe.

  1. Sometimes I use trackpad to select the text field and start typing, some of letters are being able to type in, like e, r, t, y, but others still operating Vimari commands and you can't type them in Normal mode. So what happens is sometimes I start typing and see some typed letters, but after few moment I realise that some letters are missing because of Normal mode.
  2. After facing first issue I tried to press "i" when the cursor is on the text box, Vimari enters the Insert mode, but at the same time I'm getting letter "i" inserted to the text box, so to actually start typing I have to press "i" and then backspace.

Describe the solution you'd like

  1. Not inserting "i" letter after entering the Insert mode.
  2. I would like to be able to turn on and turn off Normal mode isolation.
  3. Also I think might be nice, if in Normal mode none of the keys will be able to be typed. All keys are locked until one presses "i" to start insert mode.

Again, thanks for all the work you do!

@nbelzer
Copy link
Collaborator

nbelzer commented Sep 17, 2020

@gaisin Thanks for the nice words, I would like to extend them to all other contributors as well.

  1. This should definitely not happen nor can I reproduce the issue (playing around with the Github comment box here). This might be related to some specific website. If possible would you be able to provide a reproducible set of steps that cause this issue to appear (consistently or most of the time)? This would help me test what goes wrong and hopefully fix it.

  2. You shouldn't have to enter i to enter insert mode when trying to type text into a textfield. Vimari should automatically detect when you are in an input field and 'enable' insert mode until you unfocus the textfield. I think the main issue is figuring out why issue 1 is happening.

@horak
Copy link

horak commented Sep 17, 2020

I'm having a similar issue myself. I'm finding it only triggered (so far) on https://substack.com.

To replicate it: simply select a text box while editing or creating a publication (you'll have to be logged in for this). You can see in the following screenshot what I'm experiencing — while typing, the selector keys appear. If I hit "t", a new tab opens, etc.

Screen Shot 2020-09-17 at 1 21 17 PM

Very grateful for this app!

@ldebritto
Copy link

I'm having the same issue inside GitHub and pretty much every site I get a text box (google.com for yet another example).

Steps

  1. In normal mode, click this comment text box.
  2. Type something starting with a r will inevitably refresh the page

Vimari Settings

{
  "excludedUrls": "",
  "linkHintCharacters": "asdfjklqwerzxc",
  "detectByCursorStyle": false,
  "scrollSize": 150,
  "openTabUrl": "favorites://",
  "modifier": "control",
  "smoothScroll": true,
  "scrollDuration": 25,
  "transparentBindings": false,
  "bindings": {
      "hintToggle": "f",
      "newTabHintToggle": "shift+f",
      "scrollUp": "k",
      "scrollDown": "j",
      "scrollLeft": "h",
      "scrollRight": "l",
      "scrollUpHalfPage": "u",
      "scrollDownHalfPage": "d",
      "goToPageTop": "g g",
      "goToPageBottom": "shift+g",
      "goToFirstInput": "g i",
      "goBack": "shift+h",
      "goForward": "shift+l",
      "reload": "r",
      "tabForward": "w",
      "tabBack": "q",
      "closeTab": "x",
      "openTab": "t"
  }
}

Safari version

15.1 (17612.2.9.1.20)
macOS 12.0.1

@bjornorri
Copy link

Hi @nbelzer, this is still an issue on many websites.

For myself this is particularly annoying in the Home Assistant web interface. Some more examples are mentioned in related issue #147.

I verified that Vimium on Chrome does not have this issue. Could this be solved by re-implementing their text input detection logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants