We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If signal is received when currentRecords is empty instead of null then it will not add it to recordsToRemove list which is causing Workflow.await(() -> currentRecords.size() == 0); to wait indefinite https://github.com/temporalio/samples-java/blob/main/core/src/main/java/io/temporal/samples/batch/slidingwindow/SlidingWindowBatchWorkflowImpl.java#L130
recordsToRemove
Workflow.await(() -> currentRecords.size() == 0);
Current Code
if (currentRecords == null) { recordsToRemove.add(recordId); return; }
Expected change
if (currentRecords == null || currentRecords.isEmpty()) { recordsToRemove.add(recordId); return; }
The text was updated successfully, but these errors were encountered:
No branches or pull requests
What are you really trying to do?
Describe the bug
If signal is received when currentRecords is empty instead of null then it will not add it to
recordsToRemove
list which is causingWorkflow.await(() -> currentRecords.size() == 0);
to wait indefinitehttps://github.com/temporalio/samples-java/blob/main/core/src/main/java/io/temporal/samples/batch/slidingwindow/SlidingWindowBatchWorkflowImpl.java#L130
Current Code
Expected change
Minimal Reproduction
Environment/Versions
Additional context
The text was updated successfully, but these errors were encountered: