From 729a5d55eaf2fdad0a928bc4d8ed457f561f3512 Mon Sep 17 00:00:00 2001 From: Laura Whitaker Date: Wed, 12 Jun 2024 14:14:15 -0600 Subject: [PATCH] Dark mode audit style updates (#2152) * Update Menu component border * Add border and make cancel a ghost button by default in Modal component * Update border in DayOfMonthPicker component * Audit and update Badge types and colors * Add interactive-table-hover background color and update table row hover styles * Revert green status color * Keep text and background color in dark mode for timeline * Add light prop to Link component to set text to off white * Remove shadow and fix border width on TopNav * Fix various border colors and radius * Fix interactive ghost hover color --- .../components/batch-operations/header.svelte | 6 ++-- .../components/batch-operations/table.svelte | 6 ++-- .../event/event-group-details.svelte | 4 +-- .../event/event-history-timeline.svelte | 36 +++++++++---------- .../components/event/event-summary-row.svelte | 12 +++---- .../svg/group-details-text.svelte | 6 ++-- .../schedule/schedule-form-view.svelte | 2 +- src/lib/components/top-nav.svelte | 2 +- src/lib/components/workflow-status.svelte | 4 +-- .../workflow/pending-activities.svelte | 8 ++--- .../workflow/workflow-call-stack-error.svelte | 1 - .../workflow-compatibility-error.svelte | 1 - .../workflow/workflow-typed-error.svelte | 1 - .../workflow/workflows-summary-row.svelte | 2 +- src/lib/holocene/accordion.svelte | 16 ++++----- src/lib/holocene/alert.stories.svelte | 1 - src/lib/holocene/alert.svelte | 9 +---- src/lib/holocene/api-pagination.svelte | 1 - src/lib/holocene/badge.stories.svelte | 5 +-- src/lib/holocene/badge.svelte | 23 +++++------- src/lib/holocene/card.svelte | 2 +- src/lib/holocene/day-of-month-picker.svelte | 2 +- src/lib/holocene/drawer-content.svelte | 2 +- src/lib/holocene/drawer.svelte | 6 ++-- src/lib/holocene/link.stories.svelte | 10 +++--- src/lib/holocene/link.svelte | 10 +++--- src/lib/holocene/menu/menu.svelte | 2 +- src/lib/holocene/modal.stories.svelte | 1 - src/lib/holocene/modal.svelte | 4 +-- .../orderable-list/orderable-list-item.svelte | 2 +- .../orderable-list/orderable-list.svelte | 2 +- src/lib/holocene/table/paginated-table.svelte | 2 +- src/lib/layouts/workflow-header.svelte | 10 +++--- .../pages/workflow-pending-activities.svelte | 8 ++--- src/lib/theme/plugin.ts | 1 + src/lib/theme/variables.ts | 6 +++- .../(app)/namespaces/[namespace]/+page.svelte | 8 ++--- 37 files changed, 103 insertions(+), 121 deletions(-) diff --git a/src/lib/components/batch-operations/header.svelte b/src/lib/components/batch-operations/header.svelte index d4f702809..49762abbf 100644 --- a/src/lib/components/batch-operations/header.svelte +++ b/src/lib/components/batch-operations/header.svelte @@ -24,9 +24,9 @@ const jobStateToBadgeType: Record = { Completed: 'success', - Running: 'running', - Failed: 'error', - Unspecified: 'unspecified', + Running: 'primary', + Failed: 'danger', + Unspecified: undefined, }; diff --git a/src/lib/components/batch-operations/table.svelte b/src/lib/components/batch-operations/table.svelte index 48377118a..2fe83d378 100644 --- a/src/lib/components/batch-operations/table.svelte +++ b/src/lib/components/batch-operations/table.svelte @@ -19,9 +19,9 @@ const jobStateToBadgeType: Record = { Completed: 'success', - Running: 'running', - Failed: 'error', - Unspecified: 'unspecified', + Running: 'primary', + Failed: 'danger', + Unspecified: undefined, }; diff --git a/src/lib/components/event/event-group-details.svelte b/src/lib/components/event/event-group-details.svelte index 82b5a5a2c..5f7cde587 100644 --- a/src/lib/components/event/event-group-details.svelte +++ b/src/lib/components/event/event-group-details.svelte @@ -61,11 +61,11 @@ diff --git a/src/lib/components/lines-and-dots/svg/group-details-text.svelte b/src/lib/components/lines-and-dots/svg/group-details-text.svelte index d9d83e244..afe82e2cc 100644 --- a/src/lib/components/lines-and-dots/svg/group-details-text.svelte +++ b/src/lib/components/lines-and-dots/svg/group-details-text.svelte @@ -102,7 +102,7 @@ {/if} --> {:else if shouldDisplayAsExecutionLink(key)} {:else if shouldDisplayChildWorkflowLink(key, attributes)} {value} {:else if shouldDisplayAsTaskQueueLink(key)} - {value} {:else} diff --git a/src/lib/components/schedule/schedule-form-view.svelte b/src/lib/components/schedule/schedule-form-view.svelte index 58ecd50ae..e73d79941 100644 --- a/src/lib/components/schedule/schedule-form-view.svelte +++ b/src/lib/components/schedule/schedule-form-view.svelte @@ -145,7 +145,7 @@

{title}

-