Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for visibility for github_repository #333

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Add check for visibility for github_repository #333

merged 1 commit into from
Sep 18, 2020

Conversation

HorizonNet
Copy link
Contributor

Add a check for the visiblity property of the github_repository
resource from the GitHub provider. It checks if the visibility was not
set to "private". This complies with the latest version of the provider
(3.0.0+), which switches to visibility in favor of the private property.
Left the private property in for backward compatibility.

Resolves #326

Add a check for the visiblity property of the github_repository
resource from the GitHub provider. It checks if the visibility was not
set to "private". This complies with the latest version of the provider
(3.0.0+), which switches to visibility in favor of the private property.
Left the private property in for backward compatibility.

Resolves #326
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #333 into master will decrease coverage by 2.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   63.07%   60.87%   -2.20%     
==========================================
  Files          56       56              
  Lines        1205     1053     -152     
==========================================
- Hits          760      641     -119     
+ Misses        379      346      -33     
  Partials       66       66              
Impacted Files Coverage Δ
pkg/cli/init.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/cli/server.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/writer/json.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/writer/yaml.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/writer/xml.go 12.50% <0.00%> (-7.50%) ⬇️
pkg/iac-providers/terraform/v12/load-file.go 65.00% <0.00%> (-4.57%) ⬇️
pkg/iac-providers/kubernetes/v1/load-dir.go 83.33% <0.00%> (-3.63%) ⬇️
pkg/policy/opa/engine.go 38.67% <0.00%> (-3.33%) ⬇️
pkg/iac-providers/terraform/v12/convert.go 72.44% <0.00%> (-3.09%) ⬇️
pkg/notifications/webhook/webhook.go 23.52% <0.00%> (-2.79%) ⬇️
... and 45 more

@HorizonNet HorizonNet marked this pull request as ready for review September 17, 2020 21:17
Copy link
Contributor

@williepaul williepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@williepaul williepaul merged commit 570cc9b into tenable:master Sep 18, 2020
@HorizonNet HorizonNet deleted the issue-326 branch September 18, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private GitHub repositories are not recognized with version 3.0.0+ of GitHub provider
2 participants