Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes dockerfile build issues #385

Merged
merged 2 commits into from
Nov 17, 2020
Merged

fixes dockerfile build issues #385

merged 2 commits into from
Nov 17, 2020

Conversation

williepaul
Copy link
Contributor

  • disables CGO to prevent any dependencies from failing the build
  • the GOARCH variable was named incorrectly and not being picked up during the docker build
  • locked both the alpine and golang versions for the docker build

fixes dockerfile build issues
545692f 
- disables CGO to prevent any dependencies from failing the build
- the GOARCH variable was named incorrectly and not being picked up during the docker build
- locked both the alpine and golang versions for the docker build
@codecov
Copy link

codecov bot commented Nov 14, 2020 •
edited
Loading

Codecov Report

Merging #385 (04be644) into master (6b484b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   63.55%   63.55%           
=======================================
  Files          85       85           
  Lines        1904     1904           
=======================================
  Hits         1210     1210           
  Misses        591      591           
  Partials      103      103

kanchwala-yusuf
kanchwala-yusuf reviewed Nov 14, 2020
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cesar-rodriguez cesar-rodriguez merged commit 62a3549 into tenable:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanchwala-yusuf kanchwala-yusuf kanchwala-yusuf left review comments

@cesar-rodriguez cesar-rodriguez cesar-rodriguez approved these changes

@acc-jon acc-jon Awaiting requested review from acc-jon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williepaul @cesar-rodriguez @kanchwala-yusuf