Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#394: recognize that empty values for username and password in master… #396

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

acc-jon
Copy link
Contributor

@acc-jon acc-jon commented Nov 20, 2020

Fixes #394: recognize that empty values for username and password in master_auth block will disable basic auth

@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #396 (97830fc) into master (b92d331) will increase coverage by 0.04%.
The diff coverage is 63.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   63.50%   63.55%   +0.04%     
==========================================
  Files          76       85       +9     
  Lines        1677     1904     +227     
==========================================
+ Hits         1065     1210     +145     
- Misses        520      591      +71     
- Partials       92      103      +11     
Impacted Files Coverage Δ
pkg/iac-providers/kustomize/v3/load-dir.go 0.00% <0.00%> (ø)
pkg/iac-providers/kustomize/v3/load-file.go 0.00% <0.00%> (ø)
pkg/iac-providers/kustomize/v3/types.go 0.00% <0.00%> (ø)
pkg/policy/cloud-providers.go 100.00% <ø> (ø)
pkg/utils/path.go 78.57% <0.00%> (-10.62%) ⬇️
pkg/version/version.go 0.00% <ø> (ø)
pkg/writer/yaml.go 100.00% <ø> (ø)
pkg/utils/yaml.go 61.81% <63.15%> (-11.52%) ⬇️
pkg/iac-providers/helm/v3/load-dir.go 85.61% <85.61%> (ø)
pkg/iac-providers/helm.go 100.00% <100.00%> (ø)
... and 23 more

@cesar-rodriguez cesar-rodriguez merged commit 6a24967 into tenable:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accurics.gcp.NS.112 suggest basic auth is enabled when is not
3 participants