Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Checks for security group association defined independently from vnet #526

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

harkirat22
Copy link
Contributor

This is a proposed fix for #391

  • Added new line which will make the rule to only check for scenarios where the vnet has an associated subnet block.
  • Added another rule to throw violation for the scenarios where subnet and security group are associated using
    azurerm_subnet_network_security_group_association

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #526 (fcec126) into master (fd73ed6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   75.57%   75.57%           
=======================================
  Files          94       94           
  Lines        2227     2227           
=======================================
  Hits         1683     1683           
  Misses        401      401           
  Partials      143      143           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants