Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes in log level and messages for load iac functions #541

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

patilpankaj212
Copy link
Contributor

  1. change default terraform version to v14 from v12
  2. modified log levels and changed log messages (few) in load iac functions of all iac providers
  3. modified related unit tests
  4. added file mode validation in executor for iacDirPath and iacFilePath

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #541 (3ffda3e) into master (10d6706) will increase coverage by 0.30%.
The diff coverage is 87.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   76.98%   77.28%   +0.30%     
==========================================
  Files          98       98              
  Lines        2368     2382      +14     
==========================================
+ Hits         1823     1841      +18     
+ Misses        402      399       -3     
+ Partials      143      142       -1     
Impacted Files Coverage Δ
pkg/iac-providers/terraform.go 100.00% <ø> (ø)
pkg/iac-providers/kubernetes/v1/load-file.go 76.00% <62.50%> (ø)
pkg/iac-providers/kustomize/v3/load-dir.go 74.00% <66.66%> (+0.92%) ⬆️
pkg/iac-providers/helm/v3/load-dir.go 85.51% <85.71%> (-0.10%) ⬇️
pkg/iac-providers/kubernetes/v1/load-dir.go 83.33% <100.00%> (ø)
pkg/iac-providers/terraform/commons/load-dir.go 85.52% <100.00%> (+0.39%) ⬆️
pkg/iac-providers/terraform/commons/load-file.go 92.00% <100.00%> (+17.00%) ⬆️
pkg/runtime/validate.go 86.00% <100.00%> (+3.50%) ⬆️

@devang-gaur devang-gaur self-requested a review February 11, 2021 10:55
pkg/iac-providers/helm/v3/load-dir_test.go Outdated Show resolved Hide resolved
pkg/iac-providers/kubernetes/v1/load-file.go Outdated Show resolved Hide resolved
pkg/iac-providers/kustomize/v3/load-dir_test.go Outdated Show resolved Hide resolved
pkg/iac-providers/terraform/v12/load-dir_test.go Outdated Show resolved Hide resolved
pkg/runtime/validate.go Show resolved Hide resolved
pkg/runtime/validate_test.go Show resolved Hide resolved
@patilpankaj212 patilpankaj212 force-pushed the log-level-fixes branch 2 times, most recently from 8f0b45c to 5a861e7 Compare February 18, 2021 12:31
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf dismissed devang-gaur’s stale review February 18, 2021 17:44

all review comments have been accommodated

@kanchwala-yusuf kanchwala-yusuf merged commit c406568 into tenable:master Feb 18, 2021
@patilpankaj212 patilpankaj212 deleted the log-level-fixes branch April 7, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants