-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes in log level and messages for load iac functions #541
Merged
kanchwala-yusuf
merged 2 commits into
tenable:master
from
patilpankaj212:log-level-fixes
Feb 18, 2021
Merged
changes in log level and messages for load iac functions #541
kanchwala-yusuf
merged 2 commits into
tenable:master
from
patilpankaj212:log-level-fixes
Feb 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patilpankaj212
commented
Feb 6, 2021
- change default terraform version to v14 from v12
- modified log levels and changed log messages (few) in load iac functions of all iac providers
- modified related unit tests
- added file mode validation in executor for iacDirPath and iacFilePath
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 76.98% 77.28% +0.30%
==========================================
Files 98 98
Lines 2368 2382 +14
==========================================
+ Hits 1823 1841 +18
+ Misses 402 399 -3
+ Partials 143 142 -1
|
devang-gaur
previously requested changes
Feb 11, 2021
patilpankaj212
force-pushed
the
log-level-fixes
branch
2 times, most recently
from
February 18, 2021 12:31
8f0b45c
to
5a861e7
Compare
patilpankaj212
force-pushed
the
log-level-fixes
branch
from
February 18, 2021 17:12
5a861e7
to
3ffda3e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
kanchwala-yusuf
approved these changes
Feb 18, 2021
kanchwala-yusuf
dismissed
devang-gaur’s stale review
February 18, 2021 17:44
all review comments have been accommodated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.