Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:adding new policy and enhancing the noisy policy #575

Merged
merged 1 commit into from
Apr 26, 2021
Merged

fix:adding new policy and enhancing the noisy policy #575

merged 1 commit into from
Apr 26, 2021

Conversation

harkirat22
Copy link
Contributor

@harkirat22 harkirat22 commented Mar 2, 2021

fix proposed for #569 includes:

  1. Enhancing the existing policy to only throw violation if private_endpoint is not true and master_authorized_networks_config is not used.
  2. Included new policy with medium violation provided master_authorized_networks_config CIDR block has a public IP address associated.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #575 (582dff5) into master (f9aea57) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   77.28%   77.24%   -0.05%     
==========================================
  Files          98       98              
  Lines        2382     2386       +4     
==========================================
+ Hits         1841     1843       +2     
- Misses        399      400       +1     
- Partials      142      143       +1     
Impacted Files Coverage Δ
pkg/downloader/getter.go 86.36% <0.00%> (-1.52%) ⬇️
pkg/config/global.go 92.30% <0.00%> (ø)
cmd/terrascan/main.go
pkg/utils/dir.go 60.00% <0.00%> (ø)

@devang-gaur devang-gaur added the policy Issue concerning policy maintainers. label Apr 5, 2021
@gaurav-gogia gaurav-gogia self-requested a review April 23, 2021 06:35
@harkirat22 harkirat22 merged commit 4c66c22 into tenable:master Apr 26, 2021
devang-gaur pushed a commit to devang-gaur/terrascan that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants