adds support to configure dashboard mode in k8s validating webhook #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add new line before error messages are appended
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 74.56% 73.28% -1.29%
==========================================
Files 110 110
Lines 3082 3099 +17
==========================================
- Hits 2298 2271 -27
- Misses 609 650 +41
- Partials 175 178 +3
|
patilpankaj212
changed the title
patilpankaj212
force-pushed
the
admn-webhook-blind-mode
branch
from
ea11b5b to
91156a6
Compare
kanchwala-yusuf
approved these changes
Apr 23, 2021
| warnings: false, | ||
| allowed: true, | ||
| wantStatus: http.StatusOK, | ||
| }, | ||
| { | ||
| name: "risky request object with config that just removes some of the violations", | ||
| contentRequestPath: "./k8s_testdata/risky_testconfig.json", | ||
| contentRequestPath: filepath.Join(k8sTestData, "risky_testconfig.json"), |
There was a problem hiding this comment.
Thank you for improving the tests!
|
Kudos, SonarCloud Quality Gate passed!
|
devang-gaur
pushed a commit
to devang-gaur/terrascan
that referenced
this pull request
May 5, 2021
…lt (tenable#683) * config file not required for executor * test changes for blind mode * dashboard mode is not default * incorporate review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new attribute
dashboardis introduced fork8s-admission-controlin the terrascan config file.When
dashboardis true, violations and admission review response would be logged to db, otherwise, the violations would be logged to the console.