Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing test #740

Merged
merged 2 commits into from
May 5, 2021
Merged

Conversation

patilpankaj212
Copy link
Contributor

@patilpankaj212 patilpankaj212 commented May 5, 2021

build is failing due to a unit-test, which got introduced when #677 got merged

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #740 (2213799) into master (9c4918e) will decrease coverage by 0.18%.
The diff coverage is 59.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   73.18%   73.00%   -0.19%     
==========================================
  Files         110      110              
  Lines        3170     3178       +8     
==========================================
  Hits         2320     2320              
- Misses        668      674       +6     
- Partials      182      184       +2     
Impacted Files Coverage Δ
...c-providers/terraform/commons/module-references.go 40.00% <0.00%> (-2.11%) ⬇️
...ac-providers/terraform/commons/local-references.go 71.87% <25.00%> (-8.13%) ⬇️
...providers/terraform/commons/variable-references.go 78.46% <62.50%> (-3.51%) ⬇️
pkg/iac-providers/terraform/commons/references.go 75.51% <88.88%> (ø)
...c-providers/terraform/commons/lookup-references.go 76.00% <100.00%> (ø)

Copy link
Contributor

@Rchanger Rchanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rchanger Rchanger merged commit 0af155d into tenable:master May 5, 2021
@patilpankaj212 patilpankaj212 deleted the fix-failing-test branch May 5, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants