Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates documentation on Terrascan github action #894

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Conversation

cesar-rodriguez
Copy link
Contributor

No description provided.

@cesar-rodriguez cesar-rodriguez requested a review from amirbenv June 26, 2021 02:29
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #894 (14dee46) into master (a74765d) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   78.59%   78.64%   +0.04%     
==========================================
  Files         167      168       +1     
  Lines        4452     4518      +66     
==========================================
+ Hits         3499     3553      +54     
- Misses        732      741       +9     
- Partials      221      224       +3     
Impacted Files Coverage Δ
pkg/writer/sarif.go 89.85% <0.00%> (-5.02%) ⬇️
pkg/utils/file.go 33.33% <0.00%> (ø)
pkg/utils/dir.go 89.47% <0.00%> (+7.65%) ⬆️
pkg/utils/json.go 78.43% <0.00%> (+9.68%) ⬆️

devang-gaur
devang-gaur previously approved these changes Jun 29, 2021
Copy link
Contributor

@devang-gaur devang-gaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One word requires capitalization. minor stuff

docs/integrations/cicd.md Outdated Show resolved Hide resolved
Co-authored-by: Devang Gaur <devang.gaur@accurics.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amirbenv amirbenv merged commit decb1e9 into master Jun 29, 2021
@amirbenv amirbenv deleted the docs/githubaction branch June 29, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants