Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] negative rendering error #1956

Open
2 of 3 tasks
shuanqverymuch opened this issue Dec 11, 2024 · 1 comment
Open
2 of 3 tasks

[Bug] negative rendering error #1956

shuanqverymuch opened this issue Dec 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@shuanqverymuch
Copy link

shuanqverymuch commented Dec 11, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Version

f662231

What's Wrong?

There is a problem which can result in negative rendering error (a negative display 0).
code in webapp/packages/chat-sdk/src/utils

  if (!/^[0-9.]+$/g.test(strValue)) {
    return '0';
  }

code in webapp/packages/supersonic-fe/src/utils

  if (!/^[0-9.]+$/g.test(str)) {
    return '0';
  }

What You Expected?

It can render negative exactly.

How to Reproduce?

see [Bug] Negative percentage is formatted incorrectly and displayed as ZERO #1925

Anything Else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@shuanqverymuch shuanqverymuch added the bug Something isn't working label Dec 11, 2024
@shuanqverymuch
Copy link
Author

shuanqverymuch commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant