add missing scan target kinds #121
Conversation
| from enum import Enum | ||
|
|
||
|
|
||
| class AlertState(str, Enum): |
There was a problem hiding this comment.
I see that in many of our Enums we are extending both str and Enum. What is the gain of extending str and how do we make use of that?
There was a problem hiding this comment.
Extending both adds the possibility of use methods from a string while they're a unique member of the Enum.
zanshinsdk/common/targets.py
Outdated
There was a problem hiding this comment.
Possible nitpick:
I see in this module that all classes extend dict. These classes are models for the supported scan targets. I see that scan target speciffic values are being set in the dict, for some targets. Why do we need the dict behaviour?
If the purpose of this classes is to transport scan target data, what about implementing this using dataclasses?
There was a problem hiding this comment.
Nice questions!
I think the decision to use the classes like that is to make it easier to parse the data to what our API is expecting without breaking the snake_case pattern from Python.
Adding missing scan targets creation, and adding a single function to retrieve the OAuth link from enabled kinds.
Doing some folder updates too to make the code more lean.
✅ All tests running.
Ran 190 tests in 2.912s OK (skipped=1)