Incorrect budget validation may reject valid overlapping budget plans

[dongsam]

Summary of Bug

The implemented logic is too restrictive though since it aggregates all budgets that overlap at any time, even if they are sequential.
To illustrate this, imagine a budget A in date range 1-4, budget B in 1-2, and budget C in 3-4, all using the same source. The

current implementation sums up the rate for all those budgets, even though B and C never overlap.

This leads to rejection of budgets even if the overlaps would at no point cause the rate to go over 1.

Tasks

• enhancing the logic to only consider overlapping budgets when calculating the total rate for each time slot.

References

• No.5 of Audit Report Budget and Farming Cosmos SDK Modules v0.1

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned