This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

Move keybase to cosmos #141

Closed

2 tasks done

liamsi opened this issue Jun 19, 2018 · 1 comment

Assignees

Contributor

liamsi commented Jun 19, 2018 •

edited

Loading

As discussed with @xla and @cwgoes:

delete keybase / ledger code from go-crypto (delete keys package #142)
move keys/ledger-code to cosmos (make sure it is not used anywhere else first), ideally preserving the directory's git history
~~depends on keys package: fundraiser compatibility and HD keys (BIP 39 & BIP 32 / BIP 44) #118~~ (merged)

Rationale:

get rid of the cgo dep.
move code to where it is used (cosmos-sdk/client/lcd)
also, go-crypto & tendermint will get merged soon and we don't want the ledger/dependency live there
moving the code over to cosmos-sdk will happen in Ledger integration cosmos/cosmos-sdk#931 (by @cwgoes )

liamsi self-assigned this

Contributor

cwgoes commented Jun 20, 2018

Merged, see #143 for repo consolidation.

cwgoes closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.