-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat proposal and block parts explicitly in the spec #7946
Comments
From the perspective of the Tendermint codebase, I understand why describing the distinction is important, but from the perspective of the specification of the PBTS algorithm in relationship to the original arXiv paper, I'm not sure it's that meaningful. The number of 'messages' that a proposal is split across feels like a bit of an implementation concern to me, but perhaps there's something I'm not seeing. |
It is definitely an implementation concern. I still think we should at least have a remark in the specification that a propose message in the spec is implemented via block parts etc. I don't think we need the remark to be super precise. I just want to have it mentioned. (After all, this point raised quite some discussion regarding when |
The current state, that I should push soon: |
This probably should be make clear, both in the English and in the TLA+ spec (@Kukovec ). We probably don't need explicitly to distinct a |
The arXiv paper just talks about Propose message that contains the block, while in the implementation, there is a Propose message that only contains the hash of the block and there are block parts gossiped around. It would be great to capture the implementation more closely in the new PBTS spec.
Originally posted by @josef-widder in tendermint/spec#369 (comment)
The text was updated successfully, but these errors were encountered: