Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for spn in bank #761

Closed
lumtis opened this issue May 5, 2022 · 5 comments · Fixed by #799
Closed

Add metadata for spn in bank #761

lumtis opened this issue May 5, 2022 · 5 comments · Fixed by #799
Assignees
Milestone

Comments

@lumtis
Copy link
Contributor

lumtis commented May 5, 2022

atom metadata on the hub:

metadatas:
- base: uatom
  denom_units:
  - aliases:
    - microatom
    denom: uatom
    exponent: 0
  - aliases:
    - milliatom
    denom: matom
    exponent: 3
  - aliases: []
    denom: atom
    exponent: 6
  description: The native staking token of the Cosmos Hub.
  display: atom
  name: ""
  symbol: ""

We should implement the same with spn/mspn/uspn

@lumtis lumtis added this to the Milestone B milestone May 9, 2022
@aljo242 aljo242 self-assigned this May 11, 2022
@aljo242
Copy link
Contributor

aljo242 commented May 11, 2022

The main mechanism for setting DenomMetadata is through the x/bank genesis as seen here.

So, we just need to add this metadata to our template and final genesis for mainnet. Are we able to add this with the existing template (config.yml)?

@lumtis
Copy link
Contributor Author

lumtis commented May 11, 2022

Yes you can define any genesis state from config.yml

@lumtis
Copy link
Contributor Author

lumtis commented May 16, 2022

Hey @aljo242, anything new on this one?

Front-end team might need it

@aljo242
Copy link
Contributor

aljo242 commented May 16, 2022

Ah, I thought this was less urgent so I just started working on the claim module. I'll do this PR soon.

@lumtis
Copy link
Contributor Author

lumtis commented May 16, 2022

I wasn't aware until recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants