Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MsgAddShares message #819

Closed
lumtis opened this issue May 29, 2022 · 1 comment · Fixed by #837
Closed

Remove MsgAddShares message #819

lumtis opened this issue May 29, 2022 · 1 comment · Fixed by #837
Assignees
Labels
campaign Related to campaign module
Milestone

Comments

@lumtis
Copy link
Contributor

lumtis commented May 29, 2022

MsgAddShares message allows a coordinator to directly allocate shares for an account in a campaign

This message is a way to automatically perform the following operations:

  • Mint vouchers
  • Redeem the vouchers for a specific account

With special allocation, we now have a specialized framework to define genesis distribution for accounts decided by the coordinator. This solution is more flexible for the coordinator since the genesis distribution can be changed at any time before the launch of the mainnet. While adding shares is a non-reversible operation, the coordinator can't remove the share from the account (since it is similar to redeeming vouchers which is censorship resistant)

I suggest removing MsgAddShares message from the campaign module. The coordinator should rely on special allocation for genesis distribution
For adding shares to an account directly, the coordinator can perform the two actions:

  • Mint vouchers
  • Redeem the vouchers for a specific account

Sending those two messages is an operation that can be abstracted from the front-end, client communicating with SPN
The other benefit of removing the message is that we would have a single-entry point for allocating shares in a campaign, minting vouchers. This simplifies state transitions of the module and make it more maintainable

@lumtis lumtis added the campaign Related to campaign module label May 29, 2022
@lumtis lumtis changed the title Proposition: remove MsgAddShares message Remove MsgAddShares message May 31, 2022
@lumtis
Copy link
Contributor Author

lumtis commented May 31, 2022

As discussed, let's work on it

@lumtis lumtis added this to the Milestone B milestone May 31, 2022
@aljo242 aljo242 self-assigned this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign Related to campaign module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants