Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR-016: ABCI changes #2662

Merged
merged 9 commits into from
Oct 18, 2018
Merged

ADR-016: ABCI changes #2662

merged 9 commits into from
Oct 18, 2018

Conversation

ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Oct 18, 2018 •
edited
Loading

More from the ADR that keeps on giving, another piece of #2468

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@ebuchman ebuchman mentioned this pull request Oct 18, 2018
Closed
6 tasks
@codecov-io
Copy link

codecov-io commented Oct 18, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@14c1bae). Click here to learn what that means.
The diff coverage is 90%.

@@            Coverage Diff             @@
##             develop    #2662   +/-   ##
==========================================
  Coverage           ?   61.73%           
==========================================
  Files              ?      207           
  Lines              ?    16910           
  Branches           ?        0           
==========================================
  Hits               ?    10439           
  Misses             ?     5604           
  Partials           ?      867
Impacted Files Coverage Δ
rpc/core/abci.go 0% <0%> (ø)
p2p/node_info.go 88.33% <100%> (ø)
consensus/replay.go 56.33% <100%> (ø)

melekes
melekes approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@ebuchman ebuchman merged commit ed4ce5f into develop Oct 18, 2018
@ebuchman ebuchman deleted the bucky/versions-abci-info branch October 18, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@xla xla Awaiting requested review from xla

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebuchman @codecov-io @melekes