-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp R package to be compatible with most recent version of tensorflow-io #381
Comments
I think maybe we could also use this as a chance to clean up or even rethink the API, at least for Dataset part. There are quite some discussions with respect to caching and performance, I think we could add those to our thinking into API as well? |
@terrytangyuan @BryanCutler Some API discussions. With the upcoming 2.0 I think we could thinking about clean up APIs. I am in favor of removing unnecessarily user input when possible. However, due to the graph vs eager mismatch between 1.x vs. 2.0, it is hard to make an API that fits 1.x and 2.0 at the same time. For example, in PR #384 ParquetDataset, it is possible in 2.0 we only need user to provide I am thinking about provide a default API for 2.0 (and use
Also, the |
@yongtang Thanks for bringing this up. I am fine with the use of |
It would be easier to support this in R as well through |
@terrytangyuan I am also thinking about deprecate cifar format. Unlikely MNIST which is used by many datasets and many people generates their own MNIST. The CIFAR format itself is not that often seen. It probably makes sense to deprecate it. |
|
@yongtang Yea deprecating is fine to me. I don’t see it quite often either. |
@yongtang A lot of changes have been landed in Python API already. Let's outline what needs to be updated in the R package here and we'll re-vamp everything altogether. |
This was done in #886 but I'll revisit to make sure everything is updated and works. |
It looks the R package is pretty out-of-date. Here are some additional data sources that we support and should be added in R as well:
@yongtang @BryanCutler and others please add if I miss anything here.
The text was updated successfully, but these errors were encountered: