Skip to content

Commit

Permalink
PR #57157: Don't set MLIR_PDLL_TABLEGEN_EXE
Browse files Browse the repository at this point in the history
Imported from GitHub PR tensorflow/tensorflow#57157

With llvm/llvm-project@91b6f76 landed, external projects no longer need
to set `MLIR_PDLL_TABLEGEN_EXE`. The variable is now set as a cache
variable in MLIR upstream. Setting it in an external project breaks
cross-compilation.

This patch is similar to 77bd8ec.
Copybara import of the project:

--
54ae3dfd45fe47751e1400385377074d0ce7c0fe by Marius Brehler <marius.brehler@iml.fraunhofer.de>:

Don't set MLIR_PDLL_TABLEGEN_EXE

With llvm/llvm-project@91b6f76 landed, external projects no longer need
to set `MLIR_PDLL_TABLEGEN_EXE`. The variable is now set as a cache
variable in MLIR upstream. Setting it in an external project breaks
cross-compilation.

This patch is similar to 77bd8ec.

Merging this change closes #57157

PiperOrigin-RevId: 467945431
  • Loading branch information
marbre authored and TensorFlow MLIR Team committed Aug 16, 2022
1 parent 454bfe0 commit 4f2a00b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ if(MHLO_EXTERNAL_PROJECT_BUILD)
set(MLIR_MAIN_SRC_DIR ${LLVM_MAIN_SRC_DIR}/../mlir ) # --src-root
set(MLIR_INCLUDE_DIR ${MLIR_MAIN_SRC_DIR}/include ) # --includedir
set(MLIR_GENERATED_INCLUDE_DIR ${LLVM_BINARY_DIR}/tools/mlir/include)
set(MLIR_PDLL_TABLEGEN_EXE $<TARGET_FILE:mlir-pdll>)
include_directories(SYSTEM ${MLIR_INCLUDE_DIR})
include_directories(SYSTEM ${MLIR_GENERATED_INCLUDE_DIR})
include_directories(SYSTEM ${MLIR_TABLEGEN_OUTPUT_DIR})
Expand Down

0 comments on commit 4f2a00b

Please sign in to comment.