-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Conversation
I believe I'm done here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the changes below, please make sure each initializer is at least ran once in initializers_test -- that'd catch the syntax errors that were left here (running pylint is also enoucraged).
Implemented the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were unnamed variables, so the tests should have failed. It's strange if the test passed with this code. Please correct the code and run the tests manually to make sure they pass.
Fixed those parts and testes on my machine, should work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
PiperOrigin-RevId: 265800010
Adding kaiming uniform and normal and lecun uniform and normal initializers, besides adding the more general variance scaling initializer