Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tflite namespace #2683

Closed
andresovela opened this issue Sep 10, 2024 · 3 comments
Closed

Rename tflite namespace #2683

andresovela opened this issue Sep 10, 2024 · 3 comments
Labels

Comments

@andresovela
Copy link
Contributor

On a project I'm working on, we have a dependency both on tensorflow and tflite-micro.

We recently had an issue due to duplicated namespaces in the workspace, i.e. both tensorflow and tflite-micro use the tflite namespace.

As far as I can tell, the implementations under tensorflow/lite in the tensorflow and tflite-micro repositories have diverged significantly. I think a rename would be beneficial to avoid clashes and generally much more transparent.

I'd like to propose renaming the tflite namespace to tflm. The actual name is bikesheddable.

Are there any drawbacks, other than the huge search&replace, to having such a rename in the future?

@rascani
Copy link
Contributor

rascani commented Sep 23, 2024

There's still a good chunk of code that is regularly copied from the TFLite repository to TFLM. There is a daily sync of those sources (that is currently broken, but I'm working on that). Since not all of the sources would be able to transition to a tflm namespace, so we'd have to add qualifiers or using statements for everything in the tflm namespace to use things from the tflite namespace.

Copy link
Contributor

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Oct 19, 2024
Copy link
Contributor

"This issue is being closed because it has been marked as
stale for 5 days with no further activity."

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants