Modify CompositeRequestDataValueProcessor

[btkatoutkm]

Change HashMap to LinkedHashMap.
Because tags order changed between java7 and java8.

[kazuki43zoo]

@btkatoutkm @making

I think it is not a fundamental solution.
Because if the return type from delegated RequestDataValueProcessor was HashMap(contains multiple items), the order is not guaranteed.

How do your think?

[btkatoutkm]

I think that RequestDataValueProcessor return HashMap(only one item) in this case.
Because line117「for (RequestDataValueProcessor processor : reversedProcessors)」 processing one by one.

And add to result(LikedHashMap) in order.

cf.CompositeRequestDataValueProcessor

private final List<RequestDataValueProcessor> reversedProcessors;

@Override
public Map<String, String> getExtraHiddenFields(HttpServletRequest request) {
    Map<String, String> result = new LinkedHashMap<String, String>();
    for (RequestDataValueProcessor processor : reversedProcessors) {
        Map<String, String> map = processor.getExtraHiddenFields(request);
        if (map != null) {
            result.putAll(map);
        }
    }
    return result;
}

cf.spring-mvc.xml

<bean name="requestDataValueProcessor"
    class="org.terasoluna.gfw.web.mvc.support.CompositeRequestDataValueProcessor">
    <constructor-arg>
        <util:list>
            <bean
                class="org.terasoluna.gfw.web.token.transaction.TransactionTokenRequestDataValueProcessor" />
            <bean
                class="org.springframework.security.web.servlet.support.csrf.CsrfRequestDataValueProcessor"
                factory-method="create" />
        </util:list>
    </constructor-arg>
</bean>

[making]

The order of the result from getExtraHiddenFields depends on implementations.
In this case, the order of DataValueProcessor is important.

Though the field name is "reversed processors", the following process ignores the order:

    Map<String, String> result = new HashMap<String, String>();
    for (RequestDataValueProcessor processor : reversedProcessors) {
        Map<String, String> map = processor.getExtraHiddenFields(request);
        if (map != null) {
            result.putAll(map);
        }
    }

So LinkedHashMap is right.