Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependency on commons-logging #827

Closed
ikeyat opened this issue Jul 4, 2018 · 2 comments
Closed

Unnecessary dependency on commons-logging #827

ikeyat opened this issue Jul 4, 2018 · 2 comments

Comments

@ikeyat
Copy link
Contributor

ikeyat commented Jul 4, 2018

Description

Until v5.3.1, terasoluna-gfw-parent imports spring-core through io-platform (a.k.a Spring IO Platform). Actually it's defined in spring-boot-starter-parent that is a parent of io-platform.
Since v5.4.1, terasoluna-gfw-parent imports spring-core through spring-framework-bom to satisfy #797.

The change causes an unnecessary dependency on commons-logging on v5.4.1.
Therefore, application will include unexpected commons-logging in spite the application never use it.
(In TERASOLUNA Framework Development guideline, jcl-over-slf4j and logback are recommended instead of commons-logging)
terasoluna-gfw-parent pom should be fixed not to import commons-logging.

Possible Solutions

Candidates

  1. excludes commons-logging at terasoluna-gfw-parent pom
  2. change the version of platform-io keeping the versions of all the dependent libraries.

Affects Version/s

  • 5.4.1.RELEASE

Fix Version/s

  • 5.5.1
  • 5.4.2

Issue Links

@ikeyat
Copy link
Contributor Author

ikeyat commented Jul 4, 2018

Warning: The impact of this problem may be a separation of log system.

I'm not sure whether commons-logging takes over jcl-over-slf4j or not.
If it does, logs of legacy libraries based on commons-logging (such as Spring4, commons) may be written with commons-logging, others may be written with logback through slf4j.

To avoid this certainly, please exclude commons-logging in your application's pom.

@yoshikawaa
Copy link
Contributor

Fixed at #896. terasoluna-gfw 5.4.2 depend on spring-core using platform-bom Brussels-SR17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants